Code Review for illumos-gate

Prepared by:Garrett D'Amore <garrett@nexenta.com> on 2011-Oct-25 09:31 -0700 PDT
Workspace:/export/home/garrett/ws/illumos-gate (at a0a9eb4c5e1b)
Compare against: ssh://anonhg@hg.illumos.org/illumos-gate (at 78d9278724d7)
Summary of changes: 266 lines changed: 256 ins; 0 del; 10 mod; 41968 unchg
Patch of changes: illumos-gate.patch
Printable review: illumos-gate.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/truss/codes.c 

reguid seems to work
fix copyright
4 lines changed: 4 ins; 0 del; 0 mod; 2348 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/zpool/zpool_main.c 

reguid seems to work
Missing newline in reguid usage.
53 lines changed: 52 ins; 0 del; 1 mod; 4503 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/ztest/ztest.c 

add ztest
fix copyright
27 lines changed: 27 ins; 0 del; 0 mod; 5641 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libzfs/common/libzfs.h 

reguid seems to work
fix copyright
3 lines changed: 2 ins; 0 del; 1 mod; 709 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libzfs/common/libzfs_pool.c 

reguid seems to work
18 lines changed: 18 ins; 0 del; 0 mod; 3803 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libzfs/common/mapfile-vers 

reguid seems to work
fix copyright
3 lines changed: 2 ins; 0 del; 1 mod; 227 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man1m/zpool.1m 

Add doc for the reguid command.
17 lines changed: 16 ins; 0 del; 1 mod; 1987 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/arc.c 

reguid seems to work
50 lines changed: 46 ins; 0 del; 4 mod; 4654 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/spa.c 

reguid seems to work
send a sysevent about the changing guid.
40 lines changed: 40 ins; 0 del; 0 mod; 5885 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/spa_misc.c 

reguid seems to work
12 lines changed: 12 ins; 0 del; 0 mod; 1679 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/sys/arc.h 

reguid seems to work
fix copyright
3 lines changed: 3 ins; 0 del; 0 mod; 142 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/sys/spa.h 

reguid seems to work
2 lines changed: 2 ins; 0 del; 0 mod; 714 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/sys/spa_impl.h 

reguid seems to work
1 line changed: 1 ins; 0 del; 0 mod; 237 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/vdev.c 

reguid seems to work
5 lines changed: 5 ins; 0 del; 0 mod; 3130 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/zfs_ioctl.c 

reguid seems to work
22 lines changed: 21 ins; 0 del; 1 mod; 5121 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/fs/zfs.h 

reguid seems to work
send a sysevent about the changing guid.
4 lines changed: 3 ins; 0 del; 1 mod; 913 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/sysevent/eventdefs.h 

send a sysevent about the changing guid.
2 lines changed: 2 ins; 0 del; 0 mod; 275 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.